-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Hide User Card from config.userCard.enabled option #10545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
UI: Hide User Card from config.userCard.enabled option #10545
Conversation
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10545 +/- ##
=========================================
Coverage 16.26% 16.26%
Complexity 13389 13389
=========================================
Files 5674 5674
Lines 498927 498927
Branches 60337 60337
=========================================
+ Hits 81157 81159 +2
+ Misses 408729 408728 -1
+ Partials 9041 9040 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, manually tested it
- I locally ran the UI environment (
npm run start
) - Accessed the
ui/public/config.json
file and changed theenabled
property of theuserCard
object fromtrue
tofalse
- Verified that the card was not displayed to end users:
- Changed the
enabled
property back totrue
and verified that the card was correctly displayed to end users:
Description
This PR makes the User Card toggleable via config.json, which is particularly useful when users shouldn’t be aware of API docs or other information.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
With

"enabled": true
and whenenabled
absent from the config.jsonWith
"enabled": false
:How Has This Been Tested?
How did you try to break this feature and the system with this change?