-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix missing VMware details in zone page #10731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10731 +/- ##
=========================================
Coverage 15.17% 15.17%
Complexity 11332 11332
=========================================
Files 5415 5415
Lines 474893 474893
Branches 57920 57920
=========================================
+ Hits 72046 72050 +4
+ Misses 394792 394790 -2
+ Partials 8055 8053 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These changes are already addressed in #10647, so closing this PR |
@harikrishna-patnala @DaanHoogland |
@weizhouapache #10647 is a revert of a feature that causes several issues, this being just one of them. |
@DaanHoogland |
clear to me now. I agree with closing this PR |
yes, it is having too many side effects and needs revisiting. |
Description
This PR fixes #10730 the missing VMware details in zone page
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?