Skip to content

Fix missing VMware details in zone page #10731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

harikrishna-patnala
Copy link
Contributor

@harikrishna-patnala harikrishna-patnala commented Apr 16, 2025

Description

This PR fixes #10730 the missing VMware details in zone page

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@harikrishna-patnala
Copy link
Contributor Author

@blueorangutan ui

@harikrishna-patnala harikrishna-patnala linked an issue Apr 16, 2025 that may be closed by this pull request
@harikrishna-patnala harikrishna-patnala added this to the 4.19.3 milestone Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (f13cf59) to head (e615f0a).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10731   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
  Complexity    11332    11332           
=========================================
  Files          5415     5415           
  Lines        474893   474893           
  Branches      57920    57920           
=========================================
+ Hits          72046    72050    +4     
+ Misses       394792   394790    -2     
+ Partials       8055     8053    -2     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harikrishna-patnala
Copy link
Contributor Author

These changes are already addressed in #10647, so closing this PR

@weizhouapache
Copy link
Member

@harikrishna-patnala @DaanHoogland
I suggest to create separate PRs for the issues

@DaanHoogland
Copy link
Contributor

@harikrishna-patnala @DaanHoogland I suggest to create separate PRs for the issues

@weizhouapache #10647 is a revert of a feature that causes several issues, this being just one of them.

@weizhouapache
Copy link
Member

@harikrishna-patnala @DaanHoogland I suggest to create separate PRs for the issues

@weizhouapache #10647 is a revert of a feature that causes several issues, this being just one of them.

@DaanHoogland
do you want to revert #9925 (you meant it, right ?)

@weizhouapache
Copy link
Member

clear to me now. I agree with closing this PR
thanks @DaanHoogland @harikrishna-patnala

@DaanHoogland
Copy link
Contributor

@harikrishna-patnala @DaanHoogland I suggest to create separate PRs for the issues

@weizhouapache #10647 is a revert of a feature that causes several issues, this being just one of them.

@DaanHoogland do you want to revert #9925 (you meant it, right ?)

yes, it is having too many side effects and needs revisiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants