Skip to content

Smoke tests: Xenserver - Fix consistent failure noticed on scale VM test #10741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.20
Choose a base branch
from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes consistent failure noticed on the test_scale_vm.py test suite:
#10668 (comment)

Using the centos template as the Macchinina template registered with "Other Linux (64-bit)" does not have guest_os_details for min and max dynamic memory to be used during scaling by xenserver. Which results in failure of the test as it fails to meet the constraints of

0 <= memory-static-min(512MB) <= memory-dynamic-min(1024MB) <= memory-dynamic-max(1024MV) <= memory-static-max(512MB)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Apr 16, 2025
@Pearl1594 Pearl1594 added this to the 4.20.1 milestone Apr 16, 2025
@Pearl1594
Copy link
Contributor Author

@blueorangutan package

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.02%. Comparing base (207a2c1) to head (edf7659).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10741      +/-   ##
============================================
- Coverage     16.02%   16.02%   -0.01%     
+ Complexity    13124    13123       -1     
============================================
  Files          5652     5652              
  Lines        495921   495921              
  Branches      60053    60053              
============================================
- Hits          79463    79452      -11     
- Misses       407593   407606      +13     
+ Partials       8865     8863       -2     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Member

@blueorangutan package

@weizhouapache
Copy link
Member

good finding @Pearl1594

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@Pearl1594
Copy link
Contributor Author

I still think there is an underlying issue / behavioural change. Because this seems to have been working until 4.19 - this specific test fails from 4.20

@weizhouapache
Copy link
Member

I still think there is an underlying issue / behavioural change. Because this seems to have been working until 4.19 - this specific test fails from 4.20

ah ok, so some changes in 4.20 causes it ?

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13092

@blueorangutan
Copy link

@DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os are: ol8, ol9, debian12, rocky8, alma9, suse15, centos7, centos6, alma8, ubuntu18, ubuntu22, ubuntu20, ubuntu24. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-ol8, kvm-ol9, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-ubuntu24, kvm-debian12, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, vmware-80u2, vmware-80u3, xenserver-65sp1, xenserver-71, xenserver-74, xenserver-84, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82, xcpng83

@DaanHoogland
Copy link
Contributor

@blueorangutan test ol8 xenserver-74

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-74) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13039)

@DaanHoogland
Copy link
Contributor

@blueorangutan test ol8 xenserver-84

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + xenserver-84) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13044)

@Pearl1594
Copy link
Contributor Author

@blueorangutan test ol8 xcpng76

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng76) has been kicked to run smoke tests

@Pearl1594
Copy link
Contributor Author

@blueorangutan test ol8 xcpng82

@blueorangutan
Copy link

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13062)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13061)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:integration-test Python Warning... Python code Ahead!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants