ui,api,server: template categorization based on os #10773
Conversation
boring-cyborg
bot
added
component:api
component:management-server
component:marvin
component:storage
component:UI
Python
shwstppr
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10773 +/- ##
============================================
+ Coverage 16.13% 16.14% +0.01%
- Complexity 13217 13255 +38
============================================
Files 5651 5660 +9
Lines 496748 497474 +726
Branches 60184 60370 +186
============================================
+ Hits 80137 80323 +186
- Misses 407688 408221 +533
- Partials 8923 8930 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks nice. would be great for end-users. |
Adds new interface for image selection (template/iso) for an instance in UI. Old interface can still be used and it can be configured using UI configuration (config.json) OS categories/Guest OS categories have been improved with ability to create new categories, delete an existing category, and marking a category as featured to allow it to show up in the UI in the image selection interface. New APIs added: - addOsCategory - deleteOsCategory - updateOsCategory APIs updated: - updateOsType - listTemplates - listOsCategories Several improvements in UI especially related to forms - DeloyVM, ReinstallVM, CreateVnfAppliance, AddAutoscaleGroup. DeployVM form can now be opened from template details view with query params. Signed-off-by: Abhishek Kumar <[email protected]>
shwstppr
force-pushed
the
deployvm-improvements
branch
from
f9852f0 to
90294a6
Compare
Signed-off-by: Abhishek Kumar <[email protected]>
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13202 |
show only required elements when query params are passed Signed-off-by: Abhishek Kumar <[email protected]>
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13221 |
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an enhanced OS categorization interface for both the UI and API by adding new endpoints and updating existing ones to support operations such as adding, updating, and deleting OS categories. Key changes include:
- New API commands for managing OS categories (add, update, delete).
- Enhancements in the DAO and VO layers to support the new category properties such as featured and sortKey.
- Updates to tests and response objects to incorporate the new fields.
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| engine/schema/src/main/java/com/cloud/storage/dao/GuestOSDaoImpl.java | Added a new method to list IDs by category. |
| engine/schema/src/main/java/com/cloud/storage/GuestOSCategoryDaoImpl.java | Adjusted SQL count query for consistency. |
| engine/schema/src/main/java/com/cloud/storage/GuestOSCategoryVO.java | Included new columns (featured, sortKey) with their getters/setters. |
| api/.../*.java | Introduced and updated API commands and responses for managing OS categories. |
| api/src/main/java/org/apache/cloudstack/api/ApiConstants.java | Added new constant for ISO support. |
| api/src/main/java/com/cloud/server/ResourceTag.java | Added a new resource tag for Guest OS category. |
| api/src/main/java/org/apache/cloudstack/api/ResponseGenerator.java | Added response generation method for Guest OS categories. |
| api/src/main/java/org/apache/cloudstack/api/ManagementService.java | Declared new methods for OS category operations. |
| @@ -71,7 +77,7 @@ public String getOsDisplayName() { | |||
| return osDisplayName; | |||
| } | |||
|
|
|||
| public Map getDetails() { | |||
| public Map<String, String> getDetails() { | |||
There was a problem hiding this comment.
The getDetails() method initializes a new empty map and then checks if it is not empty, which will always return false, effectively ignoring the 'details' parameter intended to be processed. Also, remove the redundant semicolon in the map initialization ("new HashMap<>();;").
Copilot uses AI. Check for mistakes.
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13300 |
|
@blueorangutan test |
|
@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13305 |
|
[SF] Trillian test result (tid-13239)
|
|
@shwstppr is this ready for review/testing now, or is this still dev in progress? |
|
@rohityadavcloud this is largely ready for review/testing but awaiting internal testing. Also, I may add some fixes if I find any issues |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13316 |
|
@blueorangutan test |
|
@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13253)
|
|
An unrelated, weird exception failed the test, Trying again |
|
@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13256)
|
Description
Adds new interface for image selection (template/iso) for an instance in UI.
Old interface can still be used and it can be configured using UI configuration (config.json)
OS categories/Guest OS categories have been improved with ability to create new categories, delete an existing category, and marking a category as featured to allow it to show up in the UI in the image selection interface.
New APIs added:
APIs updated:
Several improvements in UI especially related to forms - DeloyVM, ReinstallVM, CreateVnfAppliance, AddAutoscaleGroup.
DeployVM form can now be opened from template/ISO details view with query params.
Reorganized (removed and added some) OS categories to the following (in the same order):
Documentation PR: apache/cloudstack-documentation#500
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?