ui: add an infinite scroll select component #10840
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10840 +/- ##
============================================
- Coverage 16.13% 16.13% -0.01%
+ Complexity 13220 13217 -3
============================================
Files 5651 5652 +1
Lines 496740 496779 +39
Branches 60183 60192 +9
============================================
+ Hits 80148 80151 +3
- Misses 407674 407703 +29
- Partials 8918 8925 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A select component which can retrieve more items from the API when scoll reaches at the end. It will allow selecting options in case of large number of items. Signed-off-by: Abhishek Kumar <[email protected]>
shwstppr
force-pushed
the
ui-add-infinitescrollselect
branch
from
d90d939 to
a05caf7
Compare
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Signed-off-by: Abhishek Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A select component which can retrieve more items from the API when scroll reaches at the end. It will allow selecting options in case of large number of items.
Current issues with the changes that need fixing/testing:
Showing name of a preselected item when it is not present in the first fetchTypes of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?