Add special Icon to Shared FileSystem Instances #10857
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10857 +/- ##
==========================================
Coverage 16.13% 16.14%
- Complexity 13225 13240 +15
==========================================
Files 5652 5655 +3
Lines 497021 497325 +304
Branches 60222 60279 +57
==========================================
+ Hits 80202 80294 +92
- Misses 407885 408088 +203
- Partials 8934 8943 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shwstppr
reviewed
May 14, 2025
| @@ -33,6 +33,9 @@ | |||
| <span v-if="(resource.icon && resource.icon.base64image || images.template || images.iso || resourceIcon) && !['router', 'systemvm', 'volume'].includes($route.path.split('/')[1])"> | |||
| <resource-icon :image="getImage(resource.icon && resource.icon.base64image || images.template || images.iso || resourceIcon)" size="4x" style="margin-right: 5px"/> | |||
| </span> | |||
| <span v-else-if="resource.vmtype === 'sharedfsvm'"> | |||
There was a problem hiding this comment.
User can still set a custom resource icon for it?
There was a problem hiding this comment.
Yes, user can set a custom icon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shared FileSystem Instance and Volumes show up in the common Instance and Volume Lists, but they behave somewhat differently from normal instances and volumes in terms of actions supported.
This PR adds the change which makes it easier to identify a Shared FileSystem Instance in the Instance list by using the Shared FileSystem Icon shown on the main menu. Previously it used the generic Debian icon.
This PR also adds a prefix to volumes used by Shared FileSystems, again to make them easier to identify among the list of all volumes.
Before:
After:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?