-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test: fix several simulator CI failures #10890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix several simulator CI failures #10890
Conversation
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10890 +/- ##
=========================================
Coverage 16.14% 16.14%
Complexity 13240 13240
=========================================
Files 5656 5656
Lines 497578 497579 +1
Branches 60332 60333 +1
=========================================
+ Hits 80310 80312 +2
- Misses 408317 408318 +1
+ Partials 8951 8949 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13449 |
oh, sorry, the issue is I will update the PR |
PR is updated @blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGMT
Sorry, @weizhouapache, for this bug. First, I made the changes on the main branch, and my tests were successful. I haven't thought that there could be an option for the driver or the provider to be null at this point
@slavkap |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13450 |
I am merging , as this fixes a blocker issue |
Description
This PR fixes lots of CI failures like
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?