Skip to content

test: fix several simulator CI failures #10890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes lots of CI failures like

image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Member Author

this is caused by #10799

However, there is no CI failures with 4.19, but there are lots of failures with 4.20

cc @slavkap

@weizhouapache weizhouapache added this to the 4.20.1 milestone May 19, 2025
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.14%. Comparing base (badf3e1) to head (09694a5).
Report is 2 commits behind head on 4.20.

Files with missing lines Patch % Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10890   +/-   ##
=========================================
  Coverage     16.14%   16.14%           
  Complexity    13240    13240           
=========================================
  Files          5656     5656           
  Lines        497578   497579    +1     
  Branches      60332    60333    +1     
=========================================
+ Hits          80310    80312    +2     
- Misses       408317   408318    +1     
+ Partials       8951     8949    -2     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.99% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13449

@weizhouapache
Copy link
Member Author

oh, sorry, the issue is dataStoreProviderManager is NULL, not storeprovider

I will update the PR

@weizhouapache
Copy link
Member Author

PR is updated
seems like an issue with merge forward

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@slavkap slavkap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGMT
Sorry, @weizhouapache, for this bug. First, I made the changes on the main branch, and my tests were successful. I haven't thought that there could be an option for the driver or the provider to be null at this point

@weizhouapache
Copy link
Member Author

code LGMT Sorry, @weizhouapache, for this bug. First, I made the changes on the main branch, and my tests were successful. I haven't thought that there could be an option for the driver or the provider to be null at this point

@slavkap
no worries, your code is fine.
it is because of missing @Inject in the merge forward

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13450

@weizhouapache weizhouapache marked this pull request as ready for review May 19, 2025 16:31
@weizhouapache
Copy link
Member Author

I am merging , as this fixes a blocker issue
If there are other issues, let 's address afterwards

@weizhouapache weizhouapache merged commit 5444261 into apache:4.20 May 19, 2025
21 of 26 checks passed
@DaanHoogland DaanHoogland deleted the 4.20-test-fix-NULL-storeProvider branch May 20, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants