NetApp ONTAP Storage Pool resize by sandeeplocharla · Pull Request #14523 · apache/cloudstack

sandeeplocharla · 2026-10-29T06:19:16Z

Description

This PR enables the user to resize Primary StoragePool created using NetApp ONTAP storage plugin.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

iSCSI type Primary StoragePool Resize

`Create Primary StoragePool of iSCSI type and Cluster scoped of size 20GiB`

`On ONTAP - backing flexVol`

`Resizing the StoragePool to 30 GiB`

`On ONTAP - backing flexVol - resized`

NFS3 type Primary StoragePool Resize

Create Primary StoragePool of NFS3 type and Cluster scoped of size 20GiB

On ONTAP - backing flexVol

Resizing the StoragePool to 30 GiB

On ONTAP - backing flexVol - resized

sandeeplocharla · 2026-10-29T12:10:45Z

@blueorangutan package

blueorangutan · 2026-10-29T12:12:05Z

@sandeeplocharla a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-10-29T13:21:29Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19835

piyush5netapp · 2026-11-10T06:05:20Z

    public static final int ONTAP_SNAPSHOT_DELETE_JOB_POLL_INTERVAL_MS = 2000;
+    /** Retry settings for FlexVolume create/resize/delete job polling. */
+    public static final int ONTAP_VOLUME_JOB_MAX_RETRIES = 10;
+    public static final int ONTAP_VOLUME_JOB_POLL_INTERVAL_MS = 1000;


How is this constant different from below constant ONTAP_FLEXVOL_JOB_POLL_INTERVAL_MS ? Check if it can be re-used.

Yep makes sense, will reuse the existing constants. Thankyou!!!

piyush5netapp · 2026-11-10T06:06:16Z

     */
    public Volume updateStorageVolume(Volume volume) {
-        return null;
+        logger.info("Resizing ONTAP FlexVolume '{}' (UUID: {}) to {} bytes", volume.getName(), volume.getUuid(), volume.getSize());


remove keyword like resize for method to be generic update and also volume.getSize().

This method gets called only to resize the flexVol. So, it should be alright to call it out this way

piyush5netapp · 2026-11-10T06:06:35Z

+        logger.info("Resizing ONTAP FlexVolume '{}' (UUID: {}) to {} bytes", volume.getName(), volume.getUuid(), volume.getSize());
+        String authHeader = OntapStorageUtils.generateAuthHeader(storage.getUsername(), storage.getPassword());
+        try {
+            Volume resizeRequest = new Volume();


rename variable to be generic update request

Yeah! makes sense but given that this method's sole purpose is to resize the flexVol, I feel the name works along.

piyush5netapp · 2026-11-10T06:07:04Z

+        String authHeader = OntapStorageUtils.generateAuthHeader(storage.getUsername(), storage.getPassword());
+        try {
+            Volume resizeRequest = new Volume();
+            resizeRequest.setSize(volume.getSize());


have null check and set only if it not null for it be to generic update method

updateStoragePool(StoragePool storagePool, Map<String, String> details) already has a 'null' check on 'newCapacityStr', so, the call wouldn't even reach here if 'volume.getSize() == null'

piyush5netapp · 2026-11-10T06:07:34Z

+            logger.info("FlexVolume '{}' (UUID: {}) resized successfully to {} bytes", volume.getName(), volume.getUuid(), volume.getSize());
+        } catch (FeignException e) {
+            if (OntapStorageUtils.isOntapObjectNotFoundError(e)) {
+                String msg = String.format("Cannot resize FlexVolume '%s' (UUID: %s): volume not found on ONTAP (404). ", volume.getName(), volume.getUuid());


same as above, remove all occurence of resize keyword.

Same as replied before, this method is currently used only for resizing the flexVol, so, until we come across an alternate usecase that uses this method, let's keep it the same.

piyush5netapp · 2026-11-10T06:08:40Z

    @Override
    public void updateStoragePool(StoragePool storagePool, Map<String, String> details) {
+        String newCapacityStr = details.get(PrimaryDataStoreLifeCycle.CAPACITY_BYTES);
+        if (newCapacityStr == null) {


is update storage pool only called for capacity bytes, if not we should skip throwing this error.

Yes, updateStoragePool gets called only to resize the capacity bytes.

It can also be called for iops change also. Since this method is generic update, instead of having null check , have not null check for changes fields.

storage pool resize (Grow and shrink) This PR...  [updateStoragePool] API now resizes the ONTAP FlexVolume backing the pool. When called with a new [capacityBytes], StorageManagerImpl (previously never called the lifecycle hook) now invokes [OntapPrimaryDatastoreLifecycle.updateStoragePool()], which calls the ONTAP REST API (PATCH /api/storage/volumes/{uuid}) and polls the async job to completion. No validation is applied — the new size is passed directly to ONTAP, which enforces all constraints and returns any errors as-is. This also includes UT's.          - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) - [ ] Major - [x] Minor - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial the flex volume is created with size 20GiB: <img width="1550" height="870" alt="Screenshot 2026-08-07 at 2 53 44 PM" src="https://github.com/user-attachments/assets/b312f4ec-b4b7-420a-9b1e-81e392a882c4" /> case 1: when A valid input for resize is filled by user: <img width="1458" height="681" alt="Screenshot 2026-08-07 at 2 54 17 PM" src="https://github.com/user-attachments/assets/bb0caf98-df9b-4d6f-ae76-0ca4f7659a0f" /> <img width="1255" height="736" alt="Screenshot 2026-08-07 at 2 54 44 PM" src="https://github.com/user-attachments/assets/7c0b8f49-213f-4163-971a-3a39c1d49936" /> after successful resize: <img width="1555" height="836" alt="Screenshot 2026-08-07 at 3 23 15 PM" src="https://github.com/user-attachments/assets/b7de8bfb-d8ca-4983-ae58-6c0c2503d943" /> case 2: capacity bytes given is smaller than ontap volume minimum size <img width="1476" height="846" alt="Screenshot 2026-08-07 at 2 49 58 PM" src="https://github.com/user-attachments/assets/a670be26-ab86-4e79-be50-86dd68bf39e9" /> case 3: capacity bytes given is smaller than ontap volume maximum size <img width="1469" height="874" alt="Screenshot 2026-08-07 at 2 52 11 PM" src="https://github.com/user-attachments/assets/da10b5c8-f9a3-4651-a1c2-404a908f4832" /> UT's for it : Ran just the update storage pool tests in storagestrategytest and primarydatastorelifecycletest <img width="856" height="773" alt="Screenshot 2026-08-14 at 4 07 37 PM" src="https://github.com/user-attachments/assets/b3d23c36-b635-48da-9403-aad5cd5685a6" /> Ran all tests in both the files: <img width="868" height="788" alt="Screenshot 2026-08-14 at 4 09 12 PM" src="https://github.com/user-attachments/assets/956e7c0c-190c-478f-be79-5a77623cb0bc" />   change?

boring-cyborg Bot added component:primary-storage component:storage labels Oct 29, 2026

sandeeplocharla marked this pull request as ready for review October 29, 2026 12:05

rajiv-jain-netapp reviewed Nov 2, 2026

View reviewed changes

Comment thread ...ap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java Resolved

piyush5netapp reviewed Nov 10, 2026

View reviewed changes

sathvikaragi and others added 2 commits November 10, 2026 18:15

Resolved comment received

bc4ccb8

sandeeplocharla force-pushed the netapp-pool-resize branch from 5bbc97e to bc4ccb8 Compare November 10, 2026 12:52

sandeeplocharla mentioned this pull request Nov 10, 2026

CSTACKEX-379: Resolving comments received on Primary storage pool resize upstream PR NetApp/cloudstack#136

Open

2 of 14 tasks

Conversation

sandeeplocharla commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

iSCSI type Primary StoragePool Resize

Create Primary StoragePool of iSCSI type and Cluster scoped of size 20GiB On ONTAP - backing flexVol Resizing the StoragePool to 30 GiB On ONTAP - backing flexVol - resized

NFS3 type Primary StoragePool Resize

Uh oh!

sandeeplocharla commented Oct 29, 2026

Uh oh!

blueorangutan commented Oct 29, 2026

Uh oh!

blueorangutan commented Oct 29, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sandeeplocharla commented Oct 29, 2026 •

edited

Loading

`Create Primary StoragePool of iSCSI type and Cluster scoped of size 20GiB`

`On ONTAP - backing flexVol`

`Resizing the StoragePool to 30 GiB`

`On ONTAP - backing flexVol - resized`