Fix hv_ss_reserve value for volumes on migration #6078

nvazquez · 2022-03-09T16:10:24Z

Description

This PR updates the volume hv_ss_reserve value for managed storage on volume migration attempt, so it can correctly set the destination size value
Fixes: #5915

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

nvazquez · 2022-03-09T16:15:11Z

@blueorangutan package

blueorangutan · 2022-03-09T16:18:02Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-03-09T17:02:05Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2812

nvazquez · 2022-03-09T17:31:32Z

@blueorangutan test

blueorangutan · 2022-03-09T17:32:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-03-10T02:04:10Z

Trillian test result (tid-3544)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29290 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3544-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py

nvazquez · 2022-03-10T02:58:51Z

@blueorangutan test

nvazquez · 2022-03-10T11:26:36Z

@blueorangutan test

blueorangutan · 2022-03-10T11:27:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez · 2022-03-10T14:15:37Z

@blueorangutan test matrix

nvazquez · 2022-03-10T15:38:56Z

@blueorangutan test matrix

blueorangutan · 2022-03-10T15:40:05Z

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-03-10T16:22:31Z

Trillian Build Failed (tid-3565)

blueorangutan · 2022-03-10T20:48:45Z

Trillian test result (tid-3558)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32325 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3558-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_snapshots_with_removed_data_store	`Error`	42.40	test_snapshots.py

nvazquez · 2022-03-11T03:50:16Z

@blueorangutan test matrix

blueorangutan · 2022-03-11T03:51:03Z

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-03-11T13:16:18Z

Trillian test result (tid-3572)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32478 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3572-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_snapshots_with_removed_data_store	`Error`	43.27	test_snapshots.py

blueorangutan · 2022-03-11T13:38:31Z

Trillian test result (tid-3571)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33930 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3571-xenserver-71.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_snapshots_with_removed_data_store	`Error`	46.81	test_snapshots.py

nvazquez · 2022-03-12T04:18:21Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2022-03-12T04:19:02Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2022-03-12T14:26:28Z

Trillian test result (tid-3586)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35307 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3586-vmware-67u3.zip
Smoke tests completed. 90 look OK, 2 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_migrate_detached_volume	`Error`	62.31	test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store	`Error`	47.54	test_snapshots.py

blueorangutan · 2022-03-12T16:57:00Z

Trillian test result (tid-3573)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 132420 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6078-t3573-vmware-65u2.zip
Smoke tests completed. 56 look OK, 35 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_01_create_template	`Error`	69.02	test_templates.py
test_CreateTemplateWithDuplicateName	`Error`	142.58	test_templates.py
test_02_create_template_with_checksum_sha1	`Error`	65.41	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	65.41	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	65.49	test_templates.py
test_05_create_template_with_no_checksum	`Error`	65.43	test_templates.py
test_03_delete_template	`Error`	1.06	test_templates.py
test_04_extract_template	`Error`	1.06	test_templates.py
test_09_list_templates_download_details	`Failure`	0.07	test_templates.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
ContextSuite context=TestDeployVMFromISO>:setup	`Error`	0.00	test_deploy_vm_iso.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
ContextSuite context=TestVolumes>:setup	`Error`	1955.93	test_volumes.py
test_3d_gpu_support	`Error`	1513.91	test_deploy_vgpu_enabled_vm.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
ContextSuite context=TestPrivateGwACL>:setup	`Error`	0.00	test_privategw_acl.py
ContextSuite context=TestDeployVmWithUserData>:setup	`Error`	0.00	test_deploy_vm_with_userdata.py
ContextSuite context=TestDeployVmWithVariedPlanners>:setup	`Error`	0.00	test_deploy_vms_with_varied_deploymentplanners.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	`Error`	0.00	test_resource_accounting.py
ContextSuite context=TestPortForwardingRules>:setup	`Error`	0.00	test_portforwardingrules.py
ContextSuite context=TestDomainsServiceOfferings>:setup	`Error`	1515.30	test_domain_service_offerings.py
test_list_clusters_metrics	`Error`	1511.95	test_metrics_api.py
test_list_vms_metrics	`Error`	0.18	test_metrics_api.py
test_04_migrate_detached_volume	`Error`	61.31	test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup	`Error`	1557.43	test_vm_life_cycle.py
test_10_attachAndDetach_iso	`Failure`	1510.73	test_vm_life_cycle.py
test_delete_account	`Error`	1511.95	test_network.py
test_delete_network_while_vm_on_it	`Error`	1.12	test_network.py
test_deploy_vm_l2network	`Error`	1.12	test_network.py
test_l2network_restart	`Error`	2.21	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	3.38	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	3.49	test_network.py
test_reboot_router	`Failure`	0.04	test_network.py
test_releaseIP	`Error`	1.65	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	1.70	test_network.py
ContextSuite context=TestVPCRedundancy>:setup	`Error`	0.00	test_vpc_redundant.py
ContextSuite context=TestNetworkACL>:setup	`Error`	0.00	test_network_acl.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.01	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.00	test_kubernetes_clusters.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	1511.94	test_service_offerings.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
ContextSuite context=TestAdapterTypeForNic>:setup	`Error`	0.00	test_nic_adapter_type.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
test_01_add_delete_kubernetes_supported_version	`Error`	1802.14	test_kubernetes_supported_versions.py
ContextSuite context=TestIsolatedNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	`Error`	0.00	test_routers_network_ops.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestInternalLb>:setup	`Error`	0.00	test_internal_lb.py
test_01_create_iso_with_checksum_sha1	`Error`	66.42	test_iso.py
test_02_create_iso_with_checksum_sha256	`Error`	66.39	test_iso.py
test_03_create_iso_with_checksum_md5	`Error`	66.39	test_iso.py
test_04_create_iso_with_no_checksum	`Error`	66.38	test_iso.py
test_01_create_iso	`Failure`	1513.37	test_iso.py
ContextSuite context=TestISO>:setup	`Error`	3025.74	test_iso.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py

shwstppr · 2022-07-08T06:58:19Z

@blueorangutan package

blueorangutan · 2022-07-08T06:59:02Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-07-08T07:54:18Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3731

shwstppr · 2022-08-12T04:23:23Z

@nvazquez is this ready review/testing or more changes needed?

nvazquez · 2022-08-12T13:18:14Z

@shwstppr it is not ready, still needs some work, will try to find some time for it and will update this PR

shwstppr · 2022-08-18T11:09:41Z

Based on discussion with @nvazquez moving this to next milestone

github-actions · 2022-09-27T07:05:15Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2022-12-13T09:00:56Z

@nvazquez can you resolve the conflicts?

rohityadavcloud · 2023-05-08T07:24:20Z

@nvazquez is this still relevant? If yes, could you fix the conflicts? Thanks.

nvazquez · 2023-05-08T19:00:55Z

@DaanHoogland @rohityadavcloud conflicts fixed, this PR was an attempt to fix the issue but is still not complete

codecov · 2023-05-08T20:06:03Z

Codecov Report

Merging #6078 (db36a00) into main (4243afb) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #6078      +/-   ##
============================================
- Coverage     12.95%   12.95%   -0.01%     
  Complexity     8986     8986              
============================================
  Files          2727     2727              
  Lines        256588   256591       +3     
  Branches      40006    40006              
============================================
  Hits          33242    33242              
- Misses       219177   219180       +3     
  Partials       4169     4169

Impacted Files	Coverage Δ
...ain/java/com/cloud/storage/StorageManagerImpl.java	`0.88% <0.00%> (-0.01%)`	⬇️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	`14.68% <0.00%> (-0.01%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2023-05-26T08:35:45Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2024-06-05T12:40:24Z

@nvazquez will this still continue?

rohityadavcloud · 2025-02-28T04:45:50Z

@nvazquez any update on this?
cc @Pearl1594

Fix hv_ss_reserve value for volumes on migration

39b8c03

nvazquez added type:bug component:migration labels Mar 9, 2022

nvazquez added this to the 4.17.0.0 milestone Mar 9, 2022

slavkap self-requested a review March 9, 2022 16:36

nvazquez added type:enhancement and removed type:bug labels Apr 5, 2022

nvazquez removed this from the 4.17.0.0 milestone Apr 5, 2022

nvazquez added this to the 4.18.0.0 milestone Apr 5, 2022

nvazquez modified the milestones: 4.18.0.0, 4.17.1.0 Apr 20, 2022

nvazquez force-pushed the main branch from c56220f to 0f4c3af Compare June 6, 2022 15:14

shwstppr assigned nvazquez Jul 29, 2022

shwstppr modified the milestones: 4.17.1.0, 4.18.0.0 Aug 18, 2022

github-actions bot added the status:has-conflicts label Sep 27, 2022

nvazquez modified the milestones: 4.18.0.0, unplanned Jan 12, 2023

Merge branch 'main' into fixhvreserveissue

db36a00

boring-cyborg bot added component:api component:storage labels May 8, 2023

github-actions bot removed the status:has-conflicts label May 8, 2023

github-actions bot added the status:has-conflicts label May 26, 2023

Fix hv_ss_reserve value for volumes on migration #6078

Are you sure you want to change the base?

Fix hv_ss_reserve value for volumes on migration #6078

Conversation

nvazquez commented Mar 9, 2022 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

nvazquez commented Mar 9, 2022

blueorangutan commented Mar 9, 2022

blueorangutan commented Mar 9, 2022

nvazquez commented Mar 9, 2022

blueorangutan commented Mar 9, 2022

blueorangutan commented Mar 10, 2022

nvazquez commented Mar 10, 2022

nvazquez commented Mar 10, 2022

blueorangutan commented Mar 10, 2022

nvazquez commented Mar 10, 2022

nvazquez commented Mar 10, 2022

blueorangutan commented Mar 10, 2022

blueorangutan commented Mar 10, 2022

blueorangutan commented Mar 10, 2022

nvazquez commented Mar 11, 2022

blueorangutan commented Mar 11, 2022

blueorangutan commented Mar 11, 2022

blueorangutan commented Mar 11, 2022

nvazquez commented Mar 12, 2022

blueorangutan commented Mar 12, 2022

blueorangutan commented Mar 12, 2022

blueorangutan commented Mar 12, 2022

shwstppr commented Jul 8, 2022

blueorangutan commented Jul 8, 2022

blueorangutan commented Jul 8, 2022

shwstppr commented Aug 12, 2022

nvazquez commented Aug 12, 2022

shwstppr commented Aug 18, 2022

github-actions bot commented Sep 27, 2022

DaanHoogland commented Dec 13, 2022

rohityadavcloud commented May 8, 2023

nvazquez commented May 8, 2023

codecov bot commented May 8, 2023

Codecov Report

github-actions bot commented May 26, 2023

DaanHoogland commented Jun 5, 2024

rohityadavcloud commented Feb 28, 2025

nvazquez commented Mar 9, 2022 •

edited

Loading