Skip to content

Reserve memory for host #6809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: 4.19
Choose a base branch
from
Draft

Reserve memory for host #6809

wants to merge 2 commits into from

Conversation

soreana
Copy link
Member

@soreana soreana commented Oct 6, 2022

Description

This pr is a follow up to the #4259 quoted the following from the pr:

By default cloudstack reserves 1Gb of RAM in hosts
using _dom0_memory field. Add a global setting
"host.reserved.mem.mb" which can used to either
increase or decrese the amount of memory which can be reserved

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

Please refer to the original pr at #4259

@soreana soreana force-pushed the host-reserve-memory branch 2 times, most recently from fe87621 to 123b056 Compare October 6, 2022 14:25
@soreana soreana marked this pull request as ready for review October 6, 2022 14:28
@soreana
Copy link
Member Author

soreana commented Oct 6, 2022

@blueorangutan package

@blueorangutan
Copy link

@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4364

@soreana
Copy link
Member Author

soreana commented Oct 7, 2022

@blueorangutan package

@blueorangutan
Copy link

@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 4369

@soreana soreana force-pushed the host-reserve-memory branch from 123b056 to b7d8d5c Compare October 7, 2022 09:21
@soreana
Copy link
Member Author

soreana commented Oct 7, 2022

@blueorangutan package

@blueorangutan
Copy link

@soreana a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4370

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-5082)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40461 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6809-t5082-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 563.98 test_kubernetes_clusters.py

@soreana
Copy link
Member Author

soreana commented Oct 10, 2022

@DaanHoogland Can I also have this one on 4.18, please ? :)

@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Oct 11, 2022
@DaanHoogland
Copy link
Contributor

@DaanHoogland Can I also have this one on 4.18, please ? :)

marked for 4.18 @soreana

@soreana soreana force-pushed the host-reserve-memory branch from b7d8d5c to 0ecab00 Compare October 14, 2022 08:02
@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6809 (SL-JID-2503)

@soreana soreana force-pushed the host-reserve-memory branch from 0ecab00 to c41c4a2 Compare October 14, 2022 08:19
@acs-robot
Copy link

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti modified the milestones: 4.19.2.0, 4.20.0.0 Jun 29, 2024
@DaanHoogland DaanHoogland modified the milestones: 4.20.0.0, 4.19.2.0 Jul 1, 2024
Sina Kashipazha and others added 2 commits July 4, 2024 16:01
@benj-n
Reserve memory for host
605b8f7 
By default cloudstack reserves 1Gb of RAM in hosts
using _dom0_memory field. Add a global setting
"host.reserved.mem.mb" which can used to either
increase or decrese the amount of memory which can be reserved
@benj-n
Fix unclosed curly brace
71da43b
@benj-n benj-n force-pushed the host-reserve-memory branch from 22ddc9e to 71da43b Compare July 4, 2024 20:22
@benj-n
Copy link
Contributor

benj-n commented Jul 4, 2024

@blueorangutan package

@blueorangutan
Copy link

@benj-n a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10252

@JoaoJandre
Copy link
Contributor

@benj-n an error was caught by checkstyle. You'll need to fix that to build.

@DaanHoogland DaanHoogland marked this pull request as draft September 18, 2024 10:54
@vladimirpetrov vladimirpetrov removed their assignment Dec 11, 2024
@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11984

DaanHoogland
DaanHoogland reviewed Jan 3, 2025
View reviewed changes
engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java
@@ -124,6 +131,8 @@
import com.cloud.utils.nio.Task;
import com.cloud.utils.time.InaccurateClock;
import org.apache.commons.lang3.StringUtils;
import org.apache.logging.log4j.ThreadContext;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import org.apache.logging.log4j.ThreadContext;

@DaanHoogland
Copy link
Contributor

@benj-n are you still working on this?

@DaanHoogland
Copy link
Contributor

moving forward, due to inactivity

@DaanHoogland DaanHoogland modified the milestones: 4.19.2, 4.20.1 Feb 3, 2025
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@Pearl1594
Copy link
Contributor

@soreana @benj-n Any update on this?

@soreana
Copy link
Member Author

soreana commented Mar 17, 2025

@soreana @benj-n Any update on this?

@Pearl1594 I no longer have access to Leaseweb's CloudStack repository. Maybe @phsm can help us on this.
I can cherry-pick the code to my personal repository and create another PR.

@github-actions GitHub Actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

@GutoVeronezi GutoVeronezi Awaiting requested review from GutoVeronezi

@wido wido Awaiting requested review from wido

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees
No one assigned
Labels
component:agent component:api component:backup component:build component:compute component:integration component:kvm component:orchestration component:storage status:has-conflicts status:waiting-for-author
Projects
ACS 4.20.1
Status: In Progress
Milestone
4.20.1
Development

Successfully merging this pull request may close these issues.