Skip to content

Github Action: Add action to auto close issues/PRs after a certain time #8667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vishesh92
Copy link
Member

Description

This PR adds a github action to close stale issues and PRs after a certain time.

This action will mark the issue/PR as stale after 90 days. It will add a label and comment marking it as stale.
If there is no activity on an issue/PR after it has been marked stale, it will get closed after 30 days.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a31449b) 30.76% compared to head (8222c94) 30.80%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8667      +/-   ##
============================================
+ Coverage     30.76%   30.80%   +0.03%     
- Complexity    33076    33128      +52     
============================================
  Files          5353     5353              
  Lines        374607   374607              
  Branches      54635    54635              
============================================
+ Hits         115238   115383     +145     
+ Misses       244099   243924     -175     
- Partials      15270    15300      +30     
Flag Coverage Δ
simulator-marvin-tests 24.68% <ø> (+0.05%) ⬆️
uitests 4.38% <ø> (ø)
unit-tests 16.43% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but, ... (not saying "no"!)
can we use some of these:
exempt-issue-labels Labels on issues exempted from stale
exempt-pr-labels Labels on PRs exempted from stale
only-labels Only issues/PRs with ALL these labels are checked
only-issue-labels Override only-labels for issues only
only-pr-labels Override only-labels for PRs only
any-of-labels Only issues/PRs with ANY of these labels are checked
any-of-issue-labels Override any-of-labels for issues only
any-of-pr-labels Override any-of-labels for PRs only

for instance with the unplanned milestone we might want to keep things around longer. or ready-for-merge we might want to exempt (during freeze)

that said lgtm

@weizhouapache
Copy link
Member

agree with Daan

we need to consider the labels.
also the current days (90/30) is too agressive I think.

looks good but, ... (not saying "no"!) can we use some of these: exempt-issue-labels Labels on issues exempted from stale exempt-pr-labels Labels on PRs exempted from stale only-labels Only issues/PRs with ALL these labels are checked only-issue-labels Override only-labels for issues only only-pr-labels Override only-labels for PRs only any-of-labels Only issues/PRs with ANY of these labels are checked any-of-issue-labels Override any-of-labels for issues only any-of-pr-labels Override any-of-labels for PRs only

for instance with the unplanned milestone we might want to keep things around longer. or ready-for-merge we might want to exempt (during freeze)

that said lgtm

@vishesh92
Copy link
Member Author

@DaanHoogland @weizhouapache Let me update the PR.

@weizhouapache After how many days should we mark stale or close the PRs?

@weizhouapache
Copy link
Member

@DaanHoogland @weizhouapache Let me update the PR.

@weizhouapache After how many days should we mark stale or close the PRs?

I just went through the issues, actually most of the issues were created in 2023 , few of them in 2022.
I am not sure how many days we should set. maybe 1 year ?

@rohityadavcloud
Copy link
Member

@vishesh92 is this being discussed on the dev@ ML ? Perhaps nudge the community (again)?

@rohityadavcloud
Copy link
Member

@vishesh92 I like the general idea of it, some questions; how does it consider an issue or PR to be stale (is it by last activity such as commits or comments, or by date of when the issue/PR was opened)? Could we do something like anything opened beyond 2yr+ is closed, as it's not fixed/resolved to the effect in the last 2yr+?

Otherwise LGTM on the general idea, the specific duration may need tweaking.

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, may need update the stale/close period based on the inputs from discussion

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - are we doing this @vishesh92 @Pearl1594 @DaanHoogland ?

@DaanHoogland
Copy link
Contributor

LGTM - are we doing this @vishesh92 @Pearl1594 @DaanHoogland ?

ha, this PR was stale ;), I think we should merge though. Fromality: did we discuss on dev@?

also @vishesh92 i would have gsoc be an exempt-issue-labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants