-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Github Action: Add action to auto close issues/PRs after a certain time #8667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0448c51
to
8222c94
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8667 +/- ##
============================================
+ Coverage 30.76% 30.80% +0.03%
- Complexity 33076 33128 +52
============================================
Files 5353 5353
Lines 374607 374607
Branches 54635 54635
============================================
+ Hits 115238 115383 +145
+ Misses 244099 243924 -175
- Partials 15270 15300 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but, ... (not saying "no"!)
can we use some of these:
exempt-issue-labels Labels on issues exempted from stale
exempt-pr-labels Labels on PRs exempted from stale
only-labels Only issues/PRs with ALL these labels are checked
only-issue-labels Override only-labels for issues only
only-pr-labels Override only-labels for PRs only
any-of-labels Only issues/PRs with ANY of these labels are checked
any-of-issue-labels Override any-of-labels for issues only
any-of-pr-labels Override any-of-labels for PRs only
for instance with the unplanned milestone we might want to keep things around longer. or ready-for-merge we might want to exempt (during freeze)
that said lgtm
agree with Daan we need to consider the labels.
|
@DaanHoogland @weizhouapache Let me update the PR. @weizhouapache After how many days should we mark stale or close the PRs? |
I just went through the issues, actually most of the issues were created in 2023 , few of them in 2022. |
@vishesh92 is this being discussed on the dev@ ML ? Perhaps nudge the community (again)? |
@vishesh92 I like the general idea of it, some questions; how does it consider an issue or PR to be stale (is it by last activity such as commits or comments, or by date of when the issue/PR was opened)? Could we do something like anything opened beyond 2yr+ is closed, as it's not fixed/resolved to the effect in the last 2yr+? Otherwise LGTM on the general idea, the specific duration may need tweaking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, may need update the stale/close period based on the inputs from discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - are we doing this @vishesh92 @Pearl1594 @DaanHoogland ?
ha, this PR was stale ;), I think we should merge though. Fromality: did we discuss on dev@? also @vishesh92 i would have gsoc be an exempt-issue-labels |
Description
This PR adds a github action to close stale issues and PRs after a certain time.
This action will mark the issue/PR as stale after 90 days. It will add a label and comment marking it as stale.
If there is no activity on an issue/PR after it has been marked stale, it will get closed after 30 days.
Types of changes