Skip to content

[WIP] Add vm instance id to volume usage record #9217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

sureshanaparti
Copy link
Contributor

Description

This PR adds vm instance id to volume usage record, addresses #7399

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sureshanaparti sureshanaparti changed the base branch from main to 4.19 June 11, 2024 10:24
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 6.89655% with 27 lines in your changes missing coverage. Please review.

Project coverage is 15.32%. Comparing base (acae5c5) to head (0ca37b4).
Report is 75 commits behind head on 4.19.

Current head 0ca37b4 differs from pull request most recent head 92e72f1

Please upload reports for the commit 92e72f1 to get more accurate results.

Files Patch % Lines
...ma/src/main/java/com/cloud/event/UsageEventVO.java 0.00% 14 Missing ⚠️
...java/com/cloud/usage/parser/VolumeUsageParser.java 0.00% 7 Missing ⚠️
...a/src/main/java/com/cloud/usage/UsageVolumeVO.java 0.00% 3 Missing ⚠️
...rc/main/java/com/cloud/usage/UsageManagerImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #9217      +/-   ##
============================================
+ Coverage     14.96%   15.32%   +0.35%     
- Complexity    11002    11652     +650     
============================================
  Files          5373     5452      +79     
  Lines        469309   476576    +7267     
  Branches      58607    58211     -396     
============================================
+ Hits          70231    73014    +2783     
- Misses       391304   395494    +4190     
- Partials       7774     8068     +294     
Flag Coverage Δ
uitests 4.20% <ø> (-0.10%) ⬇️
unittests 16.07% <6.89%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - didn't test it; perhaps this could have some test added (Marvin test?)

Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@rohityadavcloud rohityadavcloud added this to the 4.19.1.0 milestone Jun 24, 2024
@sureshanaparti sureshanaparti modified the milestones: 4.19.1.0, 4.20.0.0 Jun 24, 2024
@JoaoJandre JoaoJandre modified the milestones: 4.20.0.0, 4.21.0.0 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants