-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Disable API Key Access for users, accounts and domains #9741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
ceed660
cli changes to update user/account, list by apikeyaccess, domain leve…
abh1sar 2f276e6
UI changes for updating user/account and searchfilter in listview
abh1sar ad4171a
make the api parameters and setting accessible only to root admin
abh1sar 09bf1a0
revert changes to ui/package-lock.json
abh1sar 2869b13
minor changes to description strings
abh1sar 67c9c62
UT for ApiServer and AccountManagerImpl classes
abh1sar aadf4cb
fix pre-commit failure
abh1sar 31eb378
Merge branch 'main' into apikey
abh1sar 048642d
Added a constant for the string System
abh1sar b7085e6
Merge branch 'apikey' of https://github.com/abh1sar/cloudstack into apik
abh1sar aa6bc35
UT for searchForUsers and searchForAccounts
abh1sar 65dde8e
Merge branch 'main' into apikey
abh1sar f736d77
Fix marvin test error
abh1sar 51be0cb
Merge branch 'apikey' of https://github.com/abh1sar/cloudstack into apik
abh1sar c087de4
Merge branch '4.19'
DaanHoogland 113c700
Update schema to use idempotent add column
abh1sar d6181d5
Fix `updateTemplatePermission` when the UI is set to a language other…
lucas-a-martins a83734f
Merge remote-tracking branch 'upstream/main' into apik
abh1sar 7b24581
Added user name uuid to logging
abh1sar 3cbbb5f
Add events when api key access is changed via api or config setting
abh1sar 195da94
fix the userid for api key access update event
abh1sar b35fe8b
Fix ut failure after event logging
abh1sar 7858d0f
Convert drop down to radio-button in edit user and account
abh1sar 690073c
Add ApiKeyAccess status in User InfoCard for Users if Api key is gene…
abh1sar ae0d524
Return apiKeyAccess in user and account response only for Root Admin
abh1sar 0da6265
fixed noredist build failure
abh1sar 9363e50
Show apikeyaccess on the left panel in the user view for root admins …
abh1sar a90a7f6
don't show divider if apiKeyAccess is not shown to user
abh1sar a9805b5
Fix events generated to set Username, Account and Domain of the calle…
abh1sar 6aa116c
cli changes to update user/account, list by apikeyaccess, domain leve…
abh1sar 212bca5
UI changes for updating user/account and searchfilter in listview
abh1sar 610ef4d
make the api parameters and setting accessible only to root admin
abh1sar 6526033
revert changes to ui/package-lock.json
abh1sar 45df7f1
minor changes to description strings
abh1sar 309ec72
UT for ApiServer and AccountManagerImpl classes
abh1sar e1e51ff
fix pre-commit failure
abh1sar d6ddd14
Added a constant for the string System
abh1sar 2e09d8c
UT for searchForUsers and searchForAccounts
abh1sar 6e7538b
Fix marvin test error
abh1sar 6bb9ab9
Update schema to use idempotent add column
abh1sar 5bd9a6f
Added user name uuid to logging
abh1sar 7b54a6f
Add events when api key access is changed via api or config setting
abh1sar 6854ff4
fix the userid for api key access update event
abh1sar 3499240
Fix ut failure after event logging
abh1sar c759691
Convert drop down to radio-button in edit user and account
abh1sar 554d0c9
Add ApiKeyAccess status in User InfoCard for Users if Api key is gene…
abh1sar f64c0e6
Return apiKeyAccess in user and account response only for Root Admin
abh1sar 7bb3b6e
fixed noredist build failure
abh1sar 1ec4c1f
Show apikeyaccess on the left panel in the user view for root admins …
abh1sar 2fadea9
don't show divider if apiKeyAccess is not shown to user
abh1sar a099946
Fix events generated to set Username, Account and Domain of the calle…
abh1sar 0b508e0
Merge branch 'apikey' of https://github.com/abh1sar/cloudstack into apik
abh1sar 4da3265
Added DB upgrade path from 42000 to 42010
abh1sar 564d2b4
Merge remote-tracking branch 'upstream/4.20' into apik
abh1sar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -425,3 +425,9 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervi | |
|
||
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance', 'delete_protection', 'boolean DEFAULT FALSE COMMENT "delete protection for vm" '); | ||
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.volumes', 'delete_protection', 'boolean DEFAULT FALSE COMMENT "delete protection for volumes" '); | ||
|
||
DaanHoogland marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ALTER TABLE `cloud`.`user` | ||
ADD COLUMN `api_key_access` boolean; | ||
|
||
ALTER TABLE `cloud`.`account` | ||
ADD COLUMN `api_key_access` boolean; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use IDEMPOTENT_ADD_COLUMN call to add columns There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it targetted 4.20.1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, is that ok?