network: Add BGP+EVPN+VXLAN script to main repository and Agent package

[wido]

Description

This script can be used to use BGP+EVPN for VXLAN instead of multicast.

In order to use the script operators need to manually create a symlink:

cd /usr/share
ln -s modifyvxlan.sh cloudstack-common/scripts/vm/network/vnet/modifyvxlan-evpn.sh

Configuring BGP and EVPN is outside of the scope of CloudStack and is up to the operator to configure.

This commit just adds this script to the main repository and does not change any existing functionality.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.09%. Comparing base (bd874ea) to head (5a7e281).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #9778   +/-   ##
=========================================
  Coverage     16.09%   16.09%           
+ Complexity    12934    12933    -1     
=========================================
  Files          5644     5644           
  Lines        494587   494587           
  Branches      59964    59964           
=========================================
  Hits          79622    79622           
  Misses       406129   406129           
  Partials       8836     8836           

Flag	Coverage Δ
uitests	4.01% <ø> (ø)
unittests	16.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rohityadavcloud]

Thanks @wido LGTM - can you also propose a documentation PR at https://github.com/apache/cloudstack-documentation/pulls (where you can link to Vincent's blog) that could even as an example document how to prepare/config/setup BGP/EVPN outside of CloudStack & then use this feature.

[wido]

Thanks @wido LGTM - can you also propose a documentation PR at https://github.com/apache/cloudstack-documentation/pulls (where you can link to Vincent's blog) that could even as an example document how to prepare/config/setup BGP/EVPN outside of CloudStack & then use this feature.

Yes, I think that documentation is long overdue anyway.

[wido]

Thanks @wido LGTM - can you also propose a documentation PR at https://github.com/apache/cloudstack-documentation/pulls (where you can link to Vincent's blog) that could even as an example document how to prepare/config/setup BGP/EVPN outside of CloudStack & then use this feature.

Yes, I think that documentation is long overdue anyway.

PR open: apache/cloudstack-documentation#444

[weizhouapache]

lgtm

I have tested the script before
https://gist.github.com/wido/51cb9880d86f08f73766634d7f6df3f4
it worked fine in a single cluster.

I did not test multiple clusters/racks.

[alexandremattioli]

Glad to see this here @wido
LGTM

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[wido]

I rebased against main as there were conflicts. As I see a lot of LGTM, I think this one can merge now? As it only adds a file and doesn't change anything to the existing codebase.

[DaanHoogland]

@wido , do you want it on main (i.e. 4.21) or on 4.20(.1)?

[wido]

@wido , do you want it on main (i.e. 4.21) or on 4.20(.1)?

Main is fine!