[LANG-1795] Fix EnumUtils.getEnumMap throw IllegalStateException when keyFunction produces duplicate keys #1505
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LANG-1795
EnumUtils.getEnumMap(...) currently collect enum values using Collectors.toMap(...) without a merge function.Because the default Collectors.toMap requires the key to be unique, these methods will throw an IllegalStateException if the provided keyFunction produces duplicate keys.
Proposed fix:
Change the collection step to supply a merge function. A compatible, conservative default is to preserve the first-seen value
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.