Skip to content

Conversation

@IcoreE
Copy link
Contributor

@IcoreE IcoreE commented Nov 27, 2025

LANG-1795
EnumUtils.getEnumMap(...) currently collect enum values using Collectors.toMap(...) without a merge function.Because the default Collectors.toMap requires the key to be unique, these methods will throw an IllegalStateException if the provided keyFunction produces duplicate keys.

class EnumUtilsDuplicateKeyTest {

    enum Color {
        RED, ROSE
    }
    @Test
    void testGetEnumMapThrowsOnDuplicateKey() {
        assertThrows(IllegalStateException.class, () -> {
            EnumUtils.getEnumMap(Color.class, c -> c.name().substring(0, 1)); //Throw IllegalStateException
        });
    }
} 

Proposed fix:
Change the collection step to supply a merge function. A compatible, conservative default is to preserve the first-seen value

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request.
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants