POOL-415 Add an option to JdkProxySource allowing to unwrap UndeclaredThrowableException #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Up :) |
garydgregory
requested changes
Apr 14, 2025
There was a problem hiding this comment.
Hello @reda-alaoui
Thank you for your ping. Please see my comments.
| ObjectPool<TestObject, RuntimeException> pool = createProxiedObjectPool(true, new MyException()); | ||
|
|
||
| TestObject object = pool.borrowObject(); | ||
| try { |
There was a problem hiding this comment.
Hello @reda-alaoui
Please use assertThrows() where you can.
| caughtException = e; | ||
| } | ||
|
|
||
| if (caughtException instanceof UndeclaredThrowableException || caughtException instanceof InvocationTargetException) { |
There was a problem hiding this comment.
It would be better to refactor the test to make the expected exception unique. This will make what a subclass expects explicit, making each test class easier to understand. You can then use assertThrows() to make the test clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.apache.org/jira/browse/POOL-415