fix: Potential NPE when handling generic exceptions #1878
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Java's Throwable.getMessage() may return null, therefore when handling generic
Exceptioninstances, it is unsafe to assume thatgetMessage()will return a string.In some cases, this result gets passed to the LOG apis which does not handle nulls and thus will error with a NullPointerException.
Reproduction steps is unknown but this was discovered in my app via Sentry report:
Description
I searched for usages of
Exception eand any place where it used.getMessage()API. The.getMessage()usage was removed, and used the LOG.e(String tag, String message, Throwable e) signature to log the exception where applicable.Testing
NPM test runs successfully.
Checklist
(platform)if this change only applies to one platform (e.g.(android))