Skip to content

fix(statusbar): give statusBarView initial layout params so it cannot cover the WebView #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyril23 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

fix(statusbar): give statusBarView initial layout params so it cannot cover the WebView #2009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions framework/src/org/apache/cordova/CordovaActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,14 @@ protected void createViews() {
// Create StatusBar view that will overlay the top inset
View statusBarView = new View(this);
statusBarView.setTag("statusBarView");
// Start with a height of 0. The inset listener below sizes the view to the status bar height, but if the window
// insets never reach the root layout (observed on Android 8.0 where the decor consumes them), the view would
// otherwise keep FrameLayout's default MATCH_PARENT params and cover the whole WebView.
statusBarView.setLayoutParams(new FrameLayout.LayoutParams(
ViewGroup.LayoutParams.MATCH_PARENT,
0,
Gravity.TOP
));

// Handle Window Insets
ViewCompat.setOnApplyWindowInsetsListener(rootLayout, (v, insets) -> {
Expand Down