Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build)!: remove more gulp related dependencies #1377

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented Nov 3, 2024

Platforms affected

n/a

Motivation and Context

Require on less dependencies and try to use more internals

Description

  • Removed gulp-header replaced node:stream's Transform.
    • Added vinyl to continue supporting cases when files are fetched by gulp.src
  • Removed gulp-footer - Only added a new line when the source files already had a new line.
  • Removed gulp-rename - Only used in one spot which we replaced with fs.createWriteStream

Testing

  • npm run test
  • npm run clean
  • npm run build
  • npm run build -- --nofetch
  • npm run build:prod
  • npm run build:prod -- --nodocs
  • npm run lint
  • npm run update-docs
  • npm run serve

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu force-pushed the chore/remove-more-gulp-dependencies branch from 7d336e1 to d0dd995 Compare November 5, 2024 04:56
@erisu erisu requested a review from dpogue November 5, 2024 05:24
@erisu erisu merged commit 6cb7490 into apache:master Nov 6, 2024
1 check passed
@erisu erisu deleted the chore/remove-more-gulp-dependencies branch November 6, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants