Skip to content

Conversation

@GitToTheHub
Copy link
Contributor

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- Make clear, that the <engines> tag in plugin.xml is still required
@GitToTheHub
Copy link
Contributor Author

GitToTheHub commented Dec 8, 2025

For me it's currently not clear, if cordovaDependencies in package.json is optional for the current cli. If it is optional, this PR should fit everything,

@erisu
Copy link
Member

erisu commented Dec 9, 2025

Yes, cordovaDependencies is optional. When not defined it should just install latest or whatever version they passed in.

@GitToTheHub
Copy link
Contributor Author

Thanks for clarifying this :)

@GitToTheHub GitToTheHub merged commit c0d78b2 into master Dec 9, 2025
1 check passed
@GitToTheHub GitToTheHub deleted the pr-plugin-xml-engines-tag-still-required branch December 9, 2025 15:05
@GitToTheHub
Copy link
Contributor Author

I tested cordova-plugin-camera wihout cordovaDependencies and it installed just fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants