feat(ios): switch from spinner to progress bar - #1170
Open
GitToTheHub wants to merge 1 commit into
Open
Conversation
- PR #1169 implemented a progress bar for Android. Today it's more common to use a progress bar instead of a spinner to indicate loading of web page as it is the default for the Safari app. This aligns it with Android and use the same option `hideloadingindicator` as for Android. The old option `hidespinner` is still supported and will be an alias for `hideloadingindicator`.
Contributor
Author
|
If no one has any objections, I would merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
hideloadingindicatoras for Android. The old optionhidespinneris still supported and will be an alias forhideloadingindicator.Sample
iOS 26.5 iPhone 17 Pro Simulator
Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))