chore!: Replace nyc with c8 (with yargs v18 override)#198
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #198 +/- ##
===========================================
- Coverage 82.92% 64.50% -18.43%
===========================================
Files 5 5
Lines 82 293 +211
===========================================
+ Hits 68 189 +121
- Misses 14 104 +90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
We replaced Also, @dpogue had been overriding the "overrides": {
"c8": {
"yargs": "^18.0.0"
}
}For consistency, we could include the same override here. One thing to be aware of is that |
|
yargs 17 (which c8 depends on) is not compatible with Node 26: yargs/yargs#2509 c8 is a devDependency, so we have a bit of flexibility in terms of upgrading without forcing a major version bump to our public API |
|
definitely not a fan of using the overrides but I can replace nyc with c8 with the yargs override for the sake of consistency. |
Had to also run |
|
Didn't change branch names but did update the title and commit message accordingly. |
Co-authored-by: エリス <erisu@users.noreply.github.com>
Platforms affected
Motivation and Context
Updates
nycto the latest version which removes theuuiddependency, a source of audited vulnerabilities. v18 node engines is already satisfied with our engines that is committed into the master branch.Description
This PR is built on top of #197 so once that PR is merged, the commit count in this PR should become 1.
Testing
npm test
Checklist
(platform)if this change only applies to one platform (e.g.(android))