Skip to content

Conversation

@aminadinari19
Copy link
Contributor

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems these changes cause compile fail. Why do you make these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisonkun Thank-you for taking a look at the PR. It seems like in the newer version of zookeeper, the method that was being overridden has become final, so I just altered the access method to it.

@eolivelli
Copy link
Contributor

re-running CI

@tisonkun tisonkun requested a review from kezhuw June 16, 2025 23:39
Copy link
Member

@kezhuw kezhuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestReadOnly.testConnectionStateNewClient was flaky after ZOOKEEPER-4508, it should be fixed by ZOOKEEPER-4921 which supposed to be shipped in 3.9.4.

I am ok for it to be merged now. We could update to 3.9.4 once it merged.

@kezhuw kezhuw merged commit 8f43c75 into apache:master Jun 23, 2025
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants