chore: wire rint built in function#4372
Merged
Merged
Conversation
martin-g
approved these changes
May 21, 2026
|
|
||
| -- column with arithmetic | ||
| query | ||
| SELECT rint(v + 0.5) FROM test_rint |
Member
There was a problem hiding this comment.
Some other unary math tests do literal arguments verification too
Suggested change
| SELECT rint(v + 0.5) FROM test_rint | |
| SELECT rint(v + 0.5) FROM test_rint | |
| -- literal arguments | |
| query | |
| SELECT rint(0.5), rint(1.5), rint(-0.5), rint(2.5), rint(NULL), rint(cast('NaN' as double)) |
Contributor
Author
There was a problem hiding this comment.
Thanks @martin-g in Comet we dont test EmptyRelation queries, Comet expects a source
Member
There was a problem hiding this comment.
I was confused by some examples in the other tests:
Member
There was a problem hiding this comment.
The idea is to test the UDF with a ScalarValue, so adding FROM respective_table is a quick fix.
Contributor
Author
There was a problem hiding this comment.
oh I see, makes sense, I'll add this in follow up PR, thanks!
andygrove
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4150 .
Wire
rintApache Spark built in functionRationale for this change
What changes are included in this PR?
How are these changes tested?