Skip to content

build: upgrade Spark 4.1 to 4.1.2#4399

Merged
andygrove merged 2 commits into
apache:mainfrom
manuzhang:codex/upgrade-spark-4.1.2
Jun 2, 2026
Merged

build: upgrade Spark 4.1 to 4.1.2#4399
andygrove merged 2 commits into
apache:mainfrom
manuzhang:codex/upgrade-spark-4.1.2

Conversation

@manuzhang

@manuzhang manuzhang commented May 22, 2026

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #4380.

Rationale for this change

Spark 4.1 support should track the latest Spark 4.1 patch release. This updates
Comet's Spark 4.1 build, test, Docker, and documentation references from Spark
4.1.1 to Spark 4.1.2.

What changes are included in this PR?

  • Bumps the Spark 4.1 Maven profile and default Spark version to 4.1.2.
  • Updates Spark SQL CI to run against Spark 4.1.2.
  • Replaces the Spark SQL test patch from dev/diffs/4.1.1.diff with
    dev/diffs/4.1.2.diff generated from Spark v4.1.2.
  • Updates Kubernetes Docker image tags and user/contributor documentation
    references.

How are these changes tested?

  • git apply --check /Users/manuzhang/git/datafusion-comet/dev/diffs/4.1.2.diff
    against a clean Spark v4.1.2 checkout.
  • ./mvnw -B install -DskipTests -Dmaven.test.skip=true -Pspark-4.1
  • rg -n "4\\.1\\.1" . with historical changelog and generated-output
    exclusions.

Note: the local pre-commit hook was attempted but its Spark 4.1 scalafix phase is
blocked by the known unpublished semanticdb-scalac_2.13.17 artifact; the
targeted Spark 4.1 Maven build above passed.


Co-authored-by: @codex

@manuzhang manuzhang changed the title [codex] Upgrade Spark 4.1 to 4.1.2 build: upgrade Spark 4.1 to 4.1.2 May 22, 2026
@manuzhang manuzhang marked this pull request as ready for review May 22, 2026 03:01
@manuzhang manuzhang closed this May 22, 2026
@manuzhang manuzhang reopened this May 22, 2026
@manuzhang manuzhang force-pushed the codex/upgrade-spark-4.1.2 branch 2 times, most recently from c32a69c to 5923e78 Compare May 23, 2026 14:53
Updates the Spark 4.1 Maven profile, Docker image, docs, and Spark SQL test diff to Spark 4.1.2.

Co-authored-by: Codex <codex@openai.com>
@manuzhang manuzhang force-pushed the codex/upgrade-spark-4.1.2 branch from b8ce5f4 to fe31e41 Compare May 30, 2026 15:44
@manuzhang

Copy link
Copy Markdown
Member Author

@andygrove please help review

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI. Thanks @manuzhang

@andygrove andygrove merged commit 575877d into apache:main Jun 2, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Spark 4.1.1 to 4.1.2

2 participants