Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using tpch script from datafusion-benchmarks #12

Merged
merged 14 commits into from
Oct 4, 2024

Conversation

edmondop
Copy link
Contributor

@edmondop edmondop commented Oct 3, 2024

This PR restores tests in CI using the tpch-gen script from https://github.com/apache/datafusion-benchmarks/tree/main/tpch. As pointed out in apache/datafusion#12730, we might want, at a certain point, make these tooling more easy to consume from the various projects in the ecosystem

To get the test passing I had to:

  • ignore certain tests that seem non deterministic, the one that have an IN clause often change order, i..e in one case you have IN (A,B) and then when you rerun the test becomes `IN (B,A)
  • Strip out the byte offsets from the parquet segment. This is worth a follow up investigation since it's unclear where the non reproducibility come from

SortExec: expr=[l_returnflag@0 ASC NULLS LAST,l_linestatus@1 ASC NULLS LAST]
ProjectionExec: expr=[l_returnflag@0 as l_returnflag, l_linestatus@1 as l_linestatus, SUM(lineitem.l_quantity)@2 as sum_qty, SUM(lineitem.l_extendedprice)@3 as sum_base_price, SUM(lineitem.l_extendedprice * Int64(1) - lineitem.l_discount)@4 as sum_disc_price, SUM(lineitem.l_extendedprice * Int64(1) - lineitem.l_discount * Int64(1) + lineitem.l_tax)@5 as sum_charge, AVG(lineitem.l_quantity)@6 as avg_qty, AVG(lineitem.l_extendedprice)@7 as avg_price, AVG(lineitem.l_discount)@8 as avg_disc, COUNT(UInt8(1))@9 as count_order]
AggregateExec: mode=FinalPartitioned, gby=[l_returnflag@0 as l_returnflag, l_linestatus@1 as l_linestatus], aggr=[SUM(lineitem.l_quantity), SUM(lineitem.l_extendedprice), SUM(lineitem.l_extendedprice * Int64(1) - lineitem.l_discount), SUM(lineitem.l_extendedprice * Int64(1) - lineitem.l_discount * Int64(1) + lineitem.l_tax), AVG(lineitem.l_quantity), AVG(lineitem.l_extendedprice), AVG(lineitem.l_discount), COUNT(UInt8(1))]
Query Stage #0 (1 -> 1):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are using a single partition, the DataFusion Ray plans now only have a single query stage, i.e., they are not distributed now. We can fix this in a follow-up PR.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @edmondop!

@andygrove andygrove merged commit 2c8b8b8 into apache:main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants