Skip to content

Add support for parameter default values in SQL Server #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

aharpervc
Copy link
Contributor

This PR adds support for default values for parameters, as documented here: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver17#--default-

The concept of a parameter default value already existed on the OperateFunctionArg struct, but was hardcoded to None. That logic has been updated to conditionally consume = & parse an Expr.

Since this is relevant for SQL Server, a new test was added to sqlparser_mssql.rs accordingly.

@aharpervc aharpervc marked this pull request as ready for review May 28, 2025 21:29
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @aharpervc!
cc @alamb

@iffyio iffyio merged commit eacf00d into apache:main May 29, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants