-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of Expr
struct
#14366
base: main
Are you sure you want to change the base?
Reduce size of Expr
struct
#14366
Conversation
return Some(idx + input_len); | ||
} else { | ||
None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inconsistent return vs value
b25ba57
to
f5df767
Compare
Co-authored-by: Felipe Oliveira Carvalho <[email protected]>
I ran some build benchmarks on a GPC machine and I conclude this change does not improve the build timings
|
TBH I would be surprised if the build performance is affected by a few |
I'll try and find time to run some sql planning benchmarks |
Which issue does this PR close?
Rationale for this change
@waynexia 's comment on #14256 (comment) got me thinking maybe the build time regression had something to do with the size of
Expr
So I poked around for ways to reduce the size, and I found that currently
Expr
is 272 bytesWhat changes are included in this PR?
Expr
Expr::WindowFunction(WindowFunction
) -->Expr::WindowFunction(Box<WindowFunction>) -- which drops the size of
Exprfrom 272 to
112` bytesAre these changes tested?
functionally by CI
TODO:
Are there any user-facing changes?