Update parser recursion limit from 50 to 100 #15622
Conversation
| @@ -185,3 +185,17 @@ select ammp from a; | |||
|
|
|||
| statement ok | |||
| drop table a; | |||
|
|
|||
| # Error number of nested expressions exceeds limit | |||
| statement error DataFusion error: SQL error: RecursionLimitExceeded | |||
There was a problem hiding this comment.
Currently the error looks like
sql parser error: recursion limit exceeded
It is is good to provide a current recursion limit value as long as it is can be configured through datafusion.sql_parser.recursion_limit parameter
There was a problem hiding this comment.
I think we need 2 tests to guard the current default value, for both increments(error expecting test wouldn't give an error) and decrements(success expecting test would fail)
|
This PR is incomplete, I discovered that I didn't update the config to reflect the change. Once that change was made the sqllogictests started with a stack overflow. So the change that @alamb thought would help with that doesn't seem to have had the desired results. |
|
For some reason I can't switch this to draft, can a committer do that for me please? |
|
its usually here |
Which issue does this PR close?
Rationale for this change
A number of valid tests are failing because the recursion limit is fairly low. See #14091
What changes are included in this PR?
Updated the default recursion limit from 50 to 100.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.