feat: support min/max for struct #15667
Open
+755
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
alamb
reviewed
Apr 10, 2025
| _ => min_max_batch!(values, min), | ||
| }) | ||
| } | ||
|
|
||
| fn min_max_batch_struct(array: &ArrayRef, ordering: Ordering) -> Result<ScalarValue> { |
There was a problem hiding this comment.
What definition of "greater / less than" does this use? I think figuring out how to compare structs (like what does it mean for one struct to be bigger than the other) was not clear
There was a problem hiding this comment.
I updated partial_cmp_struct to make it more clear.
Do make it faster you could implement a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
datafusion doesn't support min/max for struct.
What changes are included in this PR?
modify min_max.rs to support it.
the performance for struct is worse than primitive types. does anyone have suggestions about optimizing it.
Are these changes tested?
UT
Are there any user-facing changes?
NO