Attach Diagnostic to syntax errors

[logan-keede]

Which issue does this PR close?

• Closes Attach Diagnostic to syntax errors #14437.

Rationale for this change

converting ParserError into DataFusionError to attach diagnostic through expected.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[logan-keede]

cc @eliaperantoni

[alamb]

Thank you @logan-keede !

Is it possible to add a test for this feature, perhaps in

datafusion/datafusion/sql/tests/cases/diagnostic.rs

Lines 156 to 163 in 63f37a3

	fn test_qualified_column_not_found() -> Result<()> {
	let query = "SELECT /*a*/person.first_namex/*a*/ FROM person";
	let spans = get_spans(query);
	let diag = do_query(query);
	assert_snapshot!(diag.message, @"column 'first_namex' not found in 'person'");
	assert_eq!(diag.span, Some(spans["a"]));
	Ok(())
	}

?

[logan-keede]

Thank you @logan-keede !

Is it possible to add a test for this feature, perhaps in

datafusion/datafusion/sql/tests/cases/diagnostic.rs

Lines 156 to 163 in 63f37a3

	fn test_qualified_column_not_found() -> Result<()> {
	let query = "SELECT /*a*/person.first_namex/*a*/ FROM person";
	let spans = get_spans(query);
	let diag = do_query(query);
	assert_snapshot!(diag.message, @"column 'first_namex' not found in 'person'");
	assert_eq!(diag.span, Some(spans["a"]));
	Ok(())
	}

?

Yes, I will do that. Thanks for the review!!