Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See the issue.
What changes are included in this PR?
I followed the proposal made by @2010YOUY01 in #18643.
is_builtin() -> boolmethod toAggregateUDF/AggregateUDFImpland toWindowUDF/WindowUDFImplAre these changes tested?
Not directly but I can't see a relevant way to test this. Suggestions are welcome.
Are there any user-facing changes?
Currently yes, but the change could be made non-breaking, see questions below.
Request for advices
I'm new to the codebase so feel free to challenge this PR. In particular, I'd like to have your opinion on the following items:
is_builtinhave a default implementation that returnsfalse? That would make this change non-breaking for users and slightly simplify this PR. But in return it would be more error-prone when implementing built-in functions.is_builtintoScalarUDF/ScalarUPDImpl? I didn't do it because it seems there doesn't exist any scalar UDF name matching in the codebase. It might be desirable to add it for the sake of consistency across all kinds of UDF.is_builtin() -> boolbyorigin() -> UDFOrigin?UDFOriginwould be something likeenum { BuiltIn, Spark, UserDefined }. Asking because it's not clear to me if functions in thedatafusion_sparkcrates should be considered built-in or not.