Minor: make signatures of SessionContext::register_* methods consistent#20873
Open
alexandreyc wants to merge 1 commit intoapache:mainfrom
Open
Minor: make signatures of SessionContext::register_* methods consistent#20873alexandreyc wants to merge 1 commit intoapache:mainfrom
SessionContext::register_* methods consistent#20873alexandreyc wants to merge 1 commit intoapache:mainfrom
Conversation
`register_arrow` consistent with the rest of `register_*` methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None.
Rationale for this change
All
register_*methods onSessionContextshould have similar signatures for the sake of API consistency.What changes are included in this PR?
Update
SessionContext::register_batchandSessionContext::register_arrowto have similar signatures than the rest ofSessionContext::register_*methods.Are these changes tested?
I don't think any tests are required for this. Type checking done by the compiler should be enough. Let me know if you disagree.
Are there any user-facing changes?
I don't think so. All previous calls to these methods should still work as before.