[branch-53] fix(spark): handle divide-by-zero in Spark mod/pmod with ANSI mode support (#20461)#20896
Open
alamb wants to merge 1 commit intoapache:branch-53from
Open
[branch-53] fix(spark): handle divide-by-zero in Spark mod/pmod with ANSI mode support (#20461)#20896alamb wants to merge 1 commit intoapache:branch-53from
mod/pmod with ANSI mode support (#20461)#20896alamb wants to merge 1 commit intoapache:branch-53from
Conversation
…e support (apache#20461) ## Which issue does this PR close? - NA. ## Rationale for this change Spark's `mod` and `pmod` functions return `NULL` on integer division by zero in legacy mode (ANSI off), but DataFusion's implementation always threw a `DivideByZero` error regardless of the ANSI mode setting. ## What changes are included in this PR? Add ANSI mode support to `spark_mod` and `spark_pmod` via enable_ansi_mode config option In legacy mode (ANSI off): division by zero returns `NULL` per-element In ANSI mode (ANSI on): division by zero throws an error (unchanged behavior) Add `try_rem` helper that handles per-element zero-divisor masking for integer arrays ## Are these changes tested? Yes: - 18 unit tests in modulus.rs (including new tests for both ANSI modes) - Updated pmod.slt and mod.slt sqllogictests with ANSI on/off coverage ## Are there any user-facing changes? Yes — mod(10, 0) and pmod(10, 0) now return NULL instead of erroring when enable_ansi_mode = false (the default), matching Spark behavior.
26 tasks
|
Thank you @alamb . There is an open PR on the comet side to wire this function but it seems like that has to wait till v53 is out . Comet PR : apache/datafusion-comet#3586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
53.0.0(Feb 2026 / Mar 2026) #19692This PR:
mod/pmodwith ANSI mode support #20461 from @davidlghellin to the branch-53 line