refactor: return Result from fallible catalog and schema methods#21944
Open
gratus00 wants to merge 2 commits intoapache:mainfrom
Open
refactor: return Result from fallible catalog and schema methods#21944gratus00 wants to merge 2 commits intoapache:mainfrom
gratus00 wants to merge 2 commits intoapache:mainfrom
Conversation
…e better replaced with ? or match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Several
CatalogProviderandSchemaProvidermethods are fallible in practice, but their signatures do not currently returnResult. That forces implementations and callers to either hide errors or treat fallible operations as infallible.This change makes those fallible paths explicit so errors can be propagated correctly through the catalog API and its downstream callers.
What changes are included in this PR?
This PR updates the following methods to return
Result:CatalogProvider::schema_namesCatalogProvider::schemaSchemaProvider::table_namesSchemaProvider::table_existIt also propagates those signature changes through the relevant implementations and call sites, including:
Are these changes tested?
Yes.
The following commands were run locally:
Are there any user-facing changes?
There are no end-user SQL or CLI behavior changes.
This is a public API change for implementers of CatalogProvider and SchemaProvider, so the api change label should be added.