minor: add higher-order function methods to SessionContext#21950
minor: add higher-order function methods to SessionContext#21950gstvg wants to merge 2 commits intoapache:mainfrom
Conversation
| match function { | ||
| RegisterFunction::Scalar(f) => { | ||
| self.state.write().register_udf(f)?; | ||
| } | ||
| RegisterFunction::Aggregate(f) => { | ||
| self.state.write().register_udaf(f)?; | ||
| } | ||
| RegisterFunction::Window(f) => { | ||
| self.state.write().register_udwf(f)?; | ||
| } | ||
| RegisterFunction::Table(name, f) => self.register_udtf(&name, f), | ||
| }; |
There was a problem hiding this comment.
If you added it to drop_function, shouldn't we also add it here?
There was a problem hiding this comment.
216542e
I think that drop_function works on all functions not only those registered via a FunctionFactory, and I wrongly thought that adding that variant would require a lot of changes and tests, so I left it for a future PR, but I checked it now and it's all user defined and nothing had to be changed/added (this match is the only usage of the Aggregate, Window and Table variants, for example), thanks
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Which issue does this PR close?
Follow-up of #21679 that forgot to add these methods to
SessionContextRationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?