Fix output_rows_skew sqllogictest flake#21958
Draft
geoffreyclaude wants to merge 1 commit intoapache:mainfrom
Draft
Fix output_rows_skew sqllogictest flake#21958geoffreyclaude wants to merge 1 commit intoapache:mainfrom
geoffreyclaude wants to merge 1 commit intoapache:mainfrom
Conversation
e3586f7 to
0473e9f
Compare
Contributor
|
I wonder if we wouldn't be better off accepting that scan orders are going to be mostly non-deterministic and either add an ORDER BY to the queries themselves or classify this metric via #21160 |
Contributor
Author
@adriangb I'll admit I didn't look too much in detail at this, my Codex just randomly fixed it while working on another task. So if you have a cleaner fix please go ahead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
output_rows_skewsqllogictest can fail nondeterministically after #21351 added dynamicFileStreamwork scheduling: reorderable sibling file scan streams may share one queue of unopened files. The failing case expects the four files to be attributed to output partitions as[4, 0, 1, 0], producingoutput_rows_skew=84.31%; CI has observed the same scan reported as100%instead.This was seen on PR #21927 and independently on
main, so it is a pre-existing test flake.What changes are included in this PR?
Adds
WITH ORDER (x)to the singleCREATE EXTERNAL TABLE skew_parquetstatement used by the four-file case inexplain_analyze.slt. That makes the scan order-preserving, which disables shared file work stealing for this assertion and keeps the expected per-partition metric deterministic.Are these changes tested?
Yes: flaky test now passes consistently.
Are there any user-facing changes?
No.