perf: speed up primitive group value interning, use less memory#21977
Open
Dandandan wants to merge 1 commit intoapache:mainfrom
Open
perf: speed up primitive group value interning, use less memory#21977Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing speed-up-single-primitive-group-by (b79d787) to 948cd09 (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing speed-up-single-primitive-group-by (b79d787) to 948cd09 (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing speed-up-single-primitive-group-by (b79d787) to 948cd09 (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
Dandandan
force-pushed
the
speed-up-single-primitive-group-by
branch
from
b79d787 to
611f091
Compare
Dandandan
changed the title
comphead
reviewed
May 2, 2026
| } | ||
|
|
||
| fn single_group_by_primitive_intern(c: &mut Criterion) { | ||
| const BATCH_SIZE: usize = 4096; |
Contributor
There was a problem hiding this comment.
should be batch size be like default?
comphead
reviewed
May 2, 2026
| EmitTo::All => { | ||
| self.map.clear(); | ||
| build_primitive(std::mem::take(&mut self.values), self.null_group.take()) | ||
| let mut values = vec![T::default_value(); self.num_groups]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
GroupValuesPrimitivestored hashes in the hash table. For single primitive group keys, storing the primitive value in the table lets hashbrown recompute hashes from the value and removes separate hash storage and values-vector lookups in the hot interning path.What changes are included in this PR?
(group_index, value)inGroupValuesPrimitiveinstead of(group_index, hash)plus a separate values vector.Benchmarks vs original stored-hash baseline:
GroupValuesPrimitive_intern/low_cardinality: 138.57 us -> 117.75 us (-15.48%)GroupValuesPrimitive_intern/high_cardinality: 1.1006 ms -> 1.0879 ms (no statistically significant change)aggregate_query_group_by_u64 15 12: 785.50 us -> 741.78 us (-5.06%)Are these changes tested?
Note:
cargo clippy --all-targets --all-features -- -D warningscurrently fails in this workspace because--all-featuresenables both benchmark allocator featuressnmallocandmimalloc;ci/scripts/rust_clippy.shis the repository CI clippy command and passed.Are there any user-facing changes?
No.