perf: passthrough last stream is SortPreservingMergeStream#23699
Draft
rluvaton wants to merge 1 commit into
Draft
perf: passthrough last stream is SortPreservingMergeStream#23699rluvaton wants to merge 1 commit into
SortPreservingMergeStream#23699rluvaton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO - fill this + add benchmark where SortExec reach to a point that we spilled 99% of data and then we create another spill file with 1% of data
Which issue does this PR close?
N/A
Rationale for this change
When we sort n streams and only 1 stream left we can avoid the whole loser tree +
RecordBatchBuilderinterleavecallWhat changes are included in this PR?
Are these changes tested?
Need to add some test for this case
Are there any user-facing changes?
Just making it faster
Waiting for this pr to be fixed before so we won't introduce memory issues:
FilterExec,RepartitionExec,HashJoinExecandAsyncFuncExecand more due toLimitedBatchCoalescerand arrowBatchCoalescerusage #23385