Skip to content

Hash bug #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leerho merged 3 commits into from
Feb 14, 2025
Merged

Hash bug #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05b76b0
Investigate Hash bug
leerho Feb 9, 2025
38df8a7
Only change required to fix the Hash Bug.
leerho Feb 12, 2025
1902d17
Added additional MurmurHash3 tests, especially to catch the Hash bug.
leerho Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/datasketches/memory/internal/MurmurHash3v4.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ public static long[] hash(final MemorySegment seg, final long offsetBytes, final
}

case 13: {
k2 ^= (seg.get(ValueLayout.JAVA_BYTE, cumOff + 12) & 0xFFFFL) << 32;
k2 ^= (seg.get(ValueLayout.JAVA_BYTE, cumOff + 12) & 0xFFL) << 32;
}
//$FALL-THROUGH$
case 12: {
Expand Down
6 changes: 3 additions & 3 deletions ...es/memory/internal/MurmurHash3v3Test.java → ...es/memory/internal/MurmurHash3v4Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
package org.apache.datasketches.memory.internal;

import static java.nio.charset.StandardCharsets.UTF_8;
import static org.apache.datasketches.memory.MurmurHash3.*;
import static org.apache.datasketches.memory.MurmurHash3.hash;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;

import java.lang.foreign.Arena;
import java.lang.foreign.MemorySegment;
import java.nio.ByteOrder;

import org.apache.datasketches.memory.Resource;
import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.MemoryRequestServer;
import org.apache.datasketches.memory.Resource;
import org.apache.datasketches.memory.WritableMemory;
import org.testng.Assert;
import org.testng.annotations.Test;
Expand All @@ -41,7 +41,7 @@
*
* @author Lee Rhodes
*/
public class MurmurHash3v3Test {
public class MurmurHash3v4Test {
private static final MemoryRequestServer memReqSvr = Resource.defaultMemReqSvr;

@Test
Expand Down
Loading