Skip to content

[Improvement-17025][UI] optimize queryLog to avoid infinite recursive invoke #17029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

[Improvement-17025][UI] optimize queryLog to avoid infinite recursive invoke #17029

wants to merge 5 commits into from
+13 −59

Conversation

ChaoquanTao
Copy link
Contributor

@ChaoquanTao ChaoquanTao commented Feb 25, 2025 •
edited by SbloodyS
Loading

Purpose of the pull request

This PR optimizes the getLog method to avoid infinite recursive invoke in front end

close #17025

Brief change log

  • Add getLog method in batch-task.tsx, stream-task.tsx and dag/index.tsx

Verify this pull request

This pull request is code cleanup without any test coverage.

@github-actions github-actions bot added the UI ui and front end related label Feb 25, 2025
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Feb 26, 2025
@SbloodyS SbloodyS added this to the 3.3.0 milestone Feb 26, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@SbloodyS SbloodyS modified the milestones: 3.3.0-alpha, 3.3.1 Mar 30, 2025
SbloodyS
SbloodyS approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@Gallardot Gallardot Awaiting requested review from Gallardot

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun

At least 2 approving reviews are required to merge this pull request.

Assignees

@ChaoquanTao ChaoquanTao

Labels
improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Milestone
3.3.1
3 participants
@ChaoquanTao @SbloodyS @taochaoquan-bosch