[Fix-17137][CLUSTER-MANAGE] Fix update time not effective #17138
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceTest.java:142
- [nitpick] The test confirms that updateTime is not null, but consider also verifying that the updateTime reflects a recent timestamp relative to the operation if such precision is required.
assertNotNull(cluster.getUpdateTime());
...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceImpl.java
Outdated
Show resolved
Hide resolved
SbloodyS
reviewed
Apr 17, 2025
...duler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ClusterServiceImpl.java
Outdated
Show resolved
Hide resolved
added 2 commits
April 17, 2025 10:10
…ive' into cluster-manage-update-not-effective
|
ruanwenjun
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17137
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md