[DSIP-92][Master] Refactor workflow serial strategy #17531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
EricGao888,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_supportSerialStrategy
branch
2 times, most recently
from
934e24d to
6f992ab
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../apache/dolphinscheduler/server/master/engine/workflow/serial/WorkflowSerialCoordinator.java
Fixed
Show fixed
Hide fixed
.../apache/dolphinscheduler/server/master/engine/workflow/serial/WorkflowSerialCoordinator.java
Fixed
Show fixed
Hide fixed
ruanwenjun
force-pushed
the
dev_wenjun_supportSerialStrategy
branch
2 times, most recently
from
7c6aa80 to
ab93648
Compare
ruanwenjun
force-pushed
the
dev_wenjun_supportSerialStrategy
branch
2 times, most recently
from
625e396 to
0aebdb1
Compare
| private Long workflowDefinitionCode; | ||
| private Integer workflowDefinitionVersion; | ||
| private WorkflowExecutionTypeEnum executionType; | ||
| private List<SerialCommandDto> serialCommands; |
Check notice
Code scanning / CodeQL
Exposing internal representation Note
3 tasks
ruanwenjun
force-pushed
the
dev_wenjun_supportSerialStrategy
branch
3 times, most recently
from
0f8ac4d to
86830db
Compare
ruanwenjun
changed the title
ruanwenjun
commented
Nov 19, 2025
.github/workflows/backend.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| version: ["3.1.9", "3.2.0"] | ||
| version: ["3.3.1"] |
SbloodyS
reviewed
Nov 20, 2025
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.4.0_schema/mysql/dolphinscheduler_ddl.sql
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_supportSerialStrategy
branch
from
86830db to
9113a61
Compare
ruanwenjun
force-pushed
the
dev_wenjun_supportSerialStrategy
branch
from
9113a61 to
06858a0
Compare
ruanwenjun
force-pushed
the
dev_wenjun_supportSerialStrategy
branch
from
06858a0 to
fd369b7
Compare
|
SbloodyS
reviewed
Nov 24, 2025
| */ | ||
|
|
||
| UPDATE t_ds_datasource SET connection_params = REPLACE(connection_params, '"publicKey"', '"privateKey"') WHERE type = 17 AND connection_params LIKE '%"publicKey"%'; | ||
| UPDATE t_ds_datasource SET connection_params = REPLACE(connection_params, '"publicKey"', '"privateKey"') WHERE type = 17 AND connection_params LIKE '%"publicKey"%'; |
Member
There was a problem hiding this comment.
Suggested change
| UPDATE t_ds_datasource SET connection_params = REPLACE(connection_params, '"publicKey"', '"privateKey"') WHERE type = 17 AND connection_params LIKE '%"publicKey"%'; | |
| UPDATE t_ds_datasource SET connection_params = REPLACE(connection_params, '"publicKey"', '"privateKey"') WHERE type = 17 AND connection_params LIKE '%"publicKey"%'; | |
| delete from t_ds_serial_command where workflow_instance_id = #{workflowInstanceId} | ||
| </select> | ||
|
|
||
| </mapper> No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| </mapper> | |
| </mapper> | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17703
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md