[Improvement-17693][HttpTask] Support cancel http task #17694
+780
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2025 14:32
njnu-seafish
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
|
SbloodyS
reviewed
Nov 25, 2025
| * @throws IOException if a network error occurs or the request is canceled during execution | ||
| * @throws RuntimeException if an unexpected error occurs during request processing | ||
| */ | ||
| public static @NonNull OkHttpResult getWithCall( |
Member
There was a problem hiding this comment.
The current get method has implemented the AutoCloseable interface, and its connection is secure, so it doesn't need to be closed again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #17693
Brief change log
add call.cancel() to cancel the HttpTask
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md