[DSIP-107] Add separate workflow instance logs for UI viewing, similar to task logs.#18130
Open
njnu-seafish wants to merge 6 commits intoapache:devfrom
Open
[DSIP-107] Add separate workflow instance logs for UI viewing, similar to task logs.#18130njnu-seafish wants to merge 6 commits intoapache:devfrom
njnu-seafish wants to merge 6 commits intoapache:devfrom
Conversation
njnu-seafish
requested review from
EricGao888,
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
SbloodyS
changed the title
# Conflicts: # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/WorkflowEventBusFireWorker.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/dispatcher/WorkerGroupDispatcher.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/workflow/statemachine/AbstractWorkflowStateAction.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/failover/TaskFailover.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/rpc/TaskExecutorEventListenerImpl.java # dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/rpc/TaskInstanceControllerImpl.java
ruanwenjun
reviewed
Apr 25, 2026
Comment on lines
+99
to
+104
| workflowInstance.setLogPath(WorkflowLogUtils.getWorkflowInstanceLogFullPath( | ||
| workflowInstance.getStartTime(), | ||
| workflowInstance.getWorkflowDefinitionCode(), | ||
| workflowInstance.getWorkflowDefinitionVersion(), | ||
| workflowInstance.getId())); | ||
|
|
Member
There was a problem hiding this comment.
It's best to inject the log path at runtime. You can write the code at CommandEngine, can add a new field at WorkflowStartLifecycleEvent.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Setter | ||
| public class WorkflowLogDiscriminator extends AbstractDiscriminator<ILoggingEvent> { | ||
|
|
||
| private String key; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
NO
Purpose of the pull request
This is an implementation scheme for separating workflow logs. for #18129
Brief change log
Add separate workflow instance logs for UI viewing, similar to task logs.
Verify this pull request
I have already tested and verified this solution in my local environment.
The log_path field in the t_ds_workflow_instance table:
Dedicated log files for workflow instances on the Master service:
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md