[Fix-18040][Service] Local parameters should have higher priority than upstream VarPool#18190
Open
leocook wants to merge 1 commit intoapache:devfrom
Open
[Fix-18040][Service] Local parameters should have higher priority than upstream VarPool#18190leocook wants to merge 1 commit intoapache:devfrom
leocook wants to merge 1 commit intoapache:devfrom
Conversation
5d49f0c to
d945d5e
Compare
…n upstream VarPool - Local IN parameters now take precedence over upstream VarPool values, aligning with the documented priority "Startup > Local > Context (VarPool) > Global > Project > Built-in". - Added unit tests to verify Local > VarPool priority and VarPool > Global when no local param collides. - Fixed timezone-dependent test that was hardcoding UTC timestamps on UTC+8 machines.
d945d5e to
a9c9fce
Compare
Contributor
Author
Summary of ChangesFixed the CI pipeline failures by resolving a timezone-dependent test issue: What was fixed
Verification completed locally
Ready for CI re-runAll local validations have passed. The CI pipeline should now complete successfully. The original flake8 failures were unrelated to this PR (Python style check on non-Python files in the project). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
Yes
Purpose of the pull request
close #18040
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
testLocalParamShouldOverrideUpstreamVarPoolin CuringParamsServiceImplTest to verify local param wins over upstream VarPool.testVarPoolShouldOverrideGlobalWhenNoLocalas a regression guard.Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.md