[Enhance](cdc) Add support for environment variable resolution in parameter mapping #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNSimba
reviewed
May 27, 2025
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/CdcTools.java
Outdated
Show resolved
Hide resolved
|
Thank you for your contribution, can this be added as a case, something like this? https://github.com/apache/doris-flink-connector/blob/master/flink-doris-connector/src/test/resources/container/e2e/mysql2doris/testMySQL2Doris.txt |
- Extracts environment variable regex pattern to a constant for reusability - Replaces inline regex compilation with a pre-compiled pattern to improve performance
buu-nguyen
force-pushed
the
cdc-env
branch
3 times, most recently
from
6737125 to
785f7c8
Compare
…E tests - Introduces a new test case `testMySQL2DorisEnvVar` that validates environment variable resolution during data syncing from MySQL to Doris. - Implements methods to set and unset environment variables for testing purposes. - Adds initialization SQL and configuration files to support the new test scenario.
Hi @JNSimba, i already added an E2E test |
|
ci failed, PTAL.@buu-nguyen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem Summary:
This PR adds support for resolving environment variables within the parameter mapping for CDC tools. It updates the
getConfigMapmethod to substitute placeholders like$VARor${VAR}with their corresponding environment variable values.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...