[Improve] support postgresql regclass type in cdc sync#658
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the PostgreSQL-to-Doris type conversion used by the CDC sync tooling to handle PostgreSQL regclass columns, preventing schema-conversion failures during whole-database sync.
Changes:
- Add
regclasshandling inPostgresType.toDorisType(...)by mapping it to DorisSTRING. - Add unit coverage for
regclassconversion at the type-mapping layer and in schema-change / DDL parsing paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flink-doris-connector/flink-doris-connector-base/src/main/java/org/apache/doris/flink/tools/cdc/postgres/PostgresType.java | Maps PostgreSQL regclass to Doris STRING to avoid unsupported-type failures. |
| flink-doris-connector/flink-doris-connector-base/src/test/java/org/apache/doris/flink/tools/cdc/postgres/PostgresTypeTest.java | Adds focused unit test verifying regclass (case-insensitive) maps to STRING. |
| flink-doris-connector/flink-doris-connector-base/src/test/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/TestJsonDebeziumSchemaChangeImplV2.java | Adds schema-change type-name test ensuring Debezium column metadata with regclass becomes STRING. |
| flink-doris-connector/flink-doris-connector-base/src/test/java/org/apache/doris/flink/sink/schema/SQLParserSchemaManagerTest.java | Adds DDL parsing test for PostgreSQL ALTER TABLE ... ADD COLUMN ... regclass → Doris STRING. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for PostgreSQL
regclasscolumns in CDC database sync.Previously, PostgreSQL whole-database sync could fail during schema conversion with: