Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]Fix string function documentation docs #1842

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

liujiwen-up
Copy link
Contributor

Versions

  • dev
  • 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

@liujiwen-up liujiwen-up changed the title Fix string function documentation docs [doc]Fix string function documentation docs Jan 17, 2025
@KassieZ KassieZ requested a review from morrySnow January 17, 2025 08:02
Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

评论了前几个文件,其他的有类似的问题。麻烦统一改一波吧


#### Arguments
```sql
COUNT_SUBSTRINGS(str, pattern)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数需要用尖括号包裹

Suggested change
COUNT_SUBSTRINGS(str, pattern)
COUNT_SUBSTRINGS(<str>, <pattern>)

Comment on lines 38 to 39
| str | The string to be searched. Type: STRING |
| pattern | The substring to match. Type: STRING |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| str | The string to be searched. Type: STRING |
| pattern | The substring to match. Type: STRING |
| `<str>` | The string to be searched. Type: STRING |
| `<pattern>` | The substring to match. Type: STRING |

## Syntax

`VARCHAR cut_to_first_significant_subdomain(VARCHAR url)`
```sql
VARCHAR CUT_TO_FIRST_SIGNIFICANT_SUBDOMAIN(VARCHAR url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要类型

Suggested change
VARCHAR CUT_TO_FIRST_SIGNIFICANT_SUBDOMAIN(VARCHAR url)
CUT_TO_FIRST_SIGNIFICANT_SUBDOMAIN(<url>)

Comment on lines 100 to 104
+----------------+
| strright(NULL, 5) |
+----------------+
| NULL |
+----------------+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个结果表格有点儿问题?101行,表格出去了

@liujiwen-up liujiwen-up requested a review from morrySnow January 20, 2025 03:20
@@ -29,14 +29,14 @@ The COUNT_SUBSTRINGS function counts the number of occurrences of a specified su
## Syntax

```sql
COUNT_SUBSTRINGS(str, pattern)
COUNT_SUBSTRINGS(VARCHAR <str>, VARCHAR <pattern>)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数不需要类型说明

Suggested change
COUNT_SUBSTRINGS(VARCHAR <str>, VARCHAR <pattern>)
COUNT_SUBSTRINGS(<str>, <pattern>)

@liujiwen-up liujiwen-up requested a review from morrySnow January 20, 2025 03:54
@KassieZ KassieZ added the bug Something is incorrect label Jan 20, 2025
@KassieZ KassieZ merged commit 63f9ae0 into apache:master Jan 23, 2025
1 check passed
@KassieZ KassieZ removed the bug Something is incorrect label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants