Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt string function doc #1849

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smallhibiscus
Copy link
Contributor

Versions

  • dev
  • 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都是相同的问题,评论到了前面的文件上。其他文件也麻烦一起修改一下吧


`VARCHAR append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)`
```sql
append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 函数名大写
  2. 不需要参数类型
  3. 参数用尖括号包起来
Suggested change
append_trailing_char_if_absent(VARCHAR str, VARCHAR trailing_char)
APPEND_TRAILING_CHAR_IF_ABSENT(<str>, <trailing_char>)

### example
| Parameters | Description |
| -- |-----------------------------|
| `str` | Target string to be judged |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `str` | Target string to be judged |
| `<str>` | Target string to be judged |

| Parameters | Description |
| -- |-----------------------------|
| `str` | Target string to be judged |
| `trailing_char` | Character to be added to the end of the string (if the character does not exist) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `trailing_char` | Character to be added to the end of the string (if the character does not exist) |
| `<trailing_char>` | Character to be added to the end of the string (if the character does not exist) |


```sql
concat(STRING <expr1> [ ,STRING <expr2> ... ])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
concat(STRING <expr1> [ ,STRING <expr2> ... ])
CONCAT(<expr> [ , <expr> ... ])


| Parameter | Description |
| -- |--------------|
| `<expr1>` | The string to be concatenated |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `<expr1>` | The string to be concatenated |
| `<expr>` | The string to be concatenated |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants